Skip to content

Conversation

jcstr
Copy link
Member

@jcstr jcstr commented Oct 28, 2020

  1. Why is this change neccesary?
    This commit add the source files needed to build the website with hugo
    and deletes the old files from the old theme.

  2. How does it address the issue?
    This commit only focus on the source files needed to build the website.
    The rendered website will be on another branch.

  3. What side effects does this change have?
    None.

@jcstr jcstr self-assigned this Oct 28, 2020
Copy link
Member

@denisse-dev denisse-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the source files to generate the website, not just the generated website.

jcstr added a commit that referenced this pull request Oct 29, 2020
1. Why is this change neccesary?
This commit deletes the theme, it focus only on the source files of the
hugo website. Also it adds an elaborated README.

2. How does it address the issue?
By deleting the theme, for this commint we don't needed it.

3. What side effects does this change have?
None.
@jcstr jcstr requested a review from denisse-dev October 29, 2020 02:30
@denisse-dev denisse-dev added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 29, 2020
@jcstr jcstr force-pushed the fix-add-source-files branch from 7a0b21f to fa1deb7 Compare October 29, 2020 05:53
Copy link

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@denisse-dev denisse-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me however, the commit message could be improved.
Could you please change the title of the commit from Rebase: combine the last 5 commits on this one to something like feature: Add Hugo project files needed to generate the site ?

Screen Shot 2020-10-29 at 10 39 36

1. Why is this change neccesary?
In order to keep the branch clean and simple.

2. How does it address the issue?
By rebasing the last 5 commits into this one.

3. What side effects does this change have?
None.
@jcstr jcstr force-pushed the fix-add-source-files branch from fa1deb7 to f988d5e Compare October 29, 2020 19:10
@jcstr
Copy link
Member Author

jcstr commented Oct 29, 2020

@da-edra Done! 😄

@denisse-dev denisse-dev self-requested a review October 30, 2020 02:27
Copy link
Member

@denisse-dev denisse-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@denisse-dev denisse-dev merged commit 4d0f95b into main Oct 30, 2020
@denisse-dev denisse-dev deleted the fix-add-source-files branch October 30, 2020 02:29
@denisse-dev denisse-dev added this to the Versión inicial milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants